fix: fail GPU E2E tests on SKU capacity issues - #9232
Merged
Conversation
sulixu
requested review from
Chou Hu (AbelHu),
Devinwong,
Sri Harsha (SriHarsha001),
Abigail Liang (abigailliang-aks-sig-node),
Abdul Asfari (aboodasfari),
Nishchay (awesomenix),
Ben Brady (benjamin-brady),
Calvin S. (calvin197),
Cameron Meissner (cameronmeissner),
Sylvain Boily (djsly),
fcher,
Ganeshkumar Ashokavardhanan (ganeshkumarashok),
janenotjung-hue,
Karen Chen (karenychen),
lilypan26,
Mark Ibrahim (mxj220),
Peter Damianov (pdamianov-dev),
Patrick W. Healy (phealy),
r2k1,
Runzhen (runzhen),
Shun Lyu (sinmentis),
Tim Wright (timmy-wright),
Thibault Cohen (titilambert),
Xu Xue (xuexu6666) and
Zachary (zachary-bailey)
as code owners
August 17, 2026 23:28
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Ubuntu-focused GPU E2E Azure DevOps pipeline configuration to stop silently skipping GPU scenarios when Azure SKU quota/capacity issues are encountered, making missing GPU coverage visible by failing the run instead.
Changes:
- Set
SKIP_TESTS_WITH_SKU_CAPACITY_ISSUEtofalsein the Ubuntu GPU E2E pipeline (.pipelines/e2e-gpu.yaml) so capacity issues fail the pipeline. - (By implication) Keep the Azure Linux GPU E2E pipeline behavior unchanged (
.pipelines/e2e-gpu-azurelinux.yamlstill has the variable set totrue).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Windows Unit Test Results 3 files 12 suites 50s ⏱️ Results for commit 3271c75. ♻️ This comment has been updated with latest results. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.pipelines/e2e-gpu.yaml:7
- The PR description says this pipeline sets
SKIP_TESTS_WITH_SKU_CAPACITY_ISSUE=false, but the current runtime expression makes ittruefor PR builds (andfalsefor non-PR builds). If the intent is to always fail GPU tests on SKU quota/capacity issues (including PR validation), this should be set tofalseunconditionally; otherwise the PR description should be updated to match the conditional behavior.
# PRs skip quota/capacity-constrained scenarios; main and scheduled runs fail them.
SKIP_TESTS_WITH_SKU_CAPACITY_ISSUE: $[eq(variables['Build.Reason'], 'PullRequest')]
Karen Chen (karenychen)
approved these changes
Aug 18, 2026
Ganeshkumar Ashokavardhanan (ganeshkumarashok)
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Sets
SKIP_TESTS_WITH_SKU_CAPACITY_ISSUE=falsefor the Ubuntu AgentBaker GPU E2E pipeline.SKU quota/capacity errors will now fail the pipeline instead of silently skipping GPU scenarios, ensuring missing GPU coverage
is visible. The Azure Linux GPU E2E pipeline remains unchanged.
Which issue(s) this PR fixes:
N/A